Candy-Labs / CandyContracts

Open-source NFT contract implementations
MIT License
11 stars 7 forks source link

Block time stamp can be manipulated #15

Closed kyokosdream closed 2 years ago

kyokosdream commented 2 years ago

The block time stamp can be manipulated so this represents an opportunity for malicious miners to attack the contract.

Open to suggestions how to refactor the code.

kyokosdream commented 2 years ago

I don't think this is an issue because the block time stamp is used for:

We need to double check to make sure the vote() function is re-entrant safe.

I believe it is since the ERC721A aux data is already set before incrementing the vote count.