Candy-Labs / CandyContracts

Open-source NFT contract implementations
MIT License
11 stars 7 forks source link

Change _safeMint to _mint #5

Closed kyokosdream closed 2 years ago

kyokosdream commented 2 years ago

https://ethereum.stackexchange.com/questions/115280/mint-vs-safemint-which-is-best-for-erc721

The _safeMint flavor of minting causes the recipient of the tokens, if it is a smart contract, to react upon receipt of the tokens.

The _safeMint function in ERC721A is not safe from re-entrancy attacks. https://github.com/chiru-labs/ERC721A/issues/92

Should implement the latest changes by @Vectorized and end reliance on OZ ReentrancyGuard

kyokosdream commented 2 years ago

8 addresses this issue. Closing.