CandyRedTele / meatballs

0 stars 0 forks source link

How are we going to handle the date overflow in shifts? #41

Closed GeoffreyBoom closed 10 years ago

GeoffreyBoom commented 10 years ago

On Fridays and Saturdays, the restaurant is open until 1am. Currently on my own branch, I have time go until 25 on Saturdays and Fridays, which doesn't make any sense. Should I change the schema to "begin_date" and "end_date" instead of just date?

GeoffreyBoom commented 10 years ago

In terms of the database end of things, it would be fine to just change 25 to 1. However, the way we choose to do it depends on how we want to display the information on the website.

rstor commented 10 years ago

seems like it would be end time of 1 like you say, and it is clear to me that the one date attribute is enough to differentiate because of the shift start and end times. like saturday(date) i work from 5pm-1am, then sunday(date) i work from 5pm-1am. that is if i understand your question correctly?

GeoffreyBoom commented 10 years ago

Yup, that makes sense. That's what I've done currently.

GeoffreyBoom commented 10 years ago

I think this one is closed.