CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

Clicking the button to go to next/prev file fails when the next/prev file is an image #1004

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Affected Version: 2.1.7.2

What steps will reproduce the problem?
1. Upload a patch with an image in the middle of the set
2. Go to web interface, and click on the file before the image
3. Click the link to go to next file

What is the expected output? What do you see instead?
I expected:
Go to next file, or skip over image
I saw:
A quick flash of loading up the top, and then browser staying on same file

Please provide any additional information below.
Chromium 11.0.696.71 (86024) Ubuntu 11.04
also Firefox 4.0.1

Original issue reported on code.google.com by hughdave...@gmail.com on 8 Jun 2011 at 2:58

GoogleCodeExporter commented 9 years ago
It seems this is only with some images.

An example one that gerrit doesn't open is attached

Original comment by hughdave...@gmail.com on 8 Jun 2011 at 3:14

Attachments:

GoogleCodeExporter commented 9 years ago
This happens on my build (v. 2.2.1) with png images that contain an alpha 
channel. (Not sure if it happens with other images or not.)

Original comment by nate.bau...@gmail.com on 17 Jan 2012 at 7:06

GoogleCodeExporter commented 9 years ago
This issue also occurs on 2.2.1 for many binary files (i.e. archives, images, 
other blobs).

Perhaps the UI should simply show the file metadata and/or note that it is a 
binary format that cannot be displayed. 

Original comment by jacob.feisley on 18 Jan 2012 at 5:05

GoogleCodeExporter commented 9 years ago
This bug still occurs and it's very annoying. Despite the fact, that I can't 
see prev/next file, I can't see it even when I'm clicking on it in Patch Set 
file list!

The only solution to review file is to checkout whole patch set.

Maybe it's time to increase the priority of this bug?

Gerrit ver. 2.5

Original comment by JKiljan...@gmail.com on 6 Feb 2013 at 10:49