CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

Comments in web view not maintaining newlines/formatting #1031

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Affected Version:
2.1.8

What steps will reproduce the problem?
1. Write a (draft, even) comment with multiple lines, save
2. Reload page

What is the expected output?
Comment across multiple lines as originally written

What do you see instead?
Comment all on one line.

Please provide any additional information below.
It would be awesome if we could get a little rich-text action going on here as 
well, but that's definitely not required.

Original issue reported on code.google.com by bushido....@gmail.com on 1 Jul 2011 at 1:25

GoogleCodeExporter commented 9 years ago
I also find this annoying.

As a poor man's workaround you can insert a space in the beginning of a new 
line to enforce the line break.

Original comment by edwin.ke...@gmail.com on 5 Jul 2011 at 11:08

GoogleCodeExporter commented 9 years ago
Changing the current formatting rules is going to be difficult. The web UI does 
the formatting after its read from the database, which means if we alter the 
formatter to honor explicit line breaks that aren't paragraph breaks, we need 
to know which version of Gerrit Code Review was used to create the comment. 
Only comments created on the new version should honor explicit line breaks, 
older comments should continue to format as they do now.

Food for thought.

Original comment by sop@google.com on 6 Jul 2011 at 3:05

GoogleCodeExporter commented 9 years ago
duplicates Issue 527 (with a slightly different background)

Original comment by oswald.b...@gmx.de on 13 Dec 2011 at 7:29