search

CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

Gerrit 2.9 init installs Verified Label #2798

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
We upgraded from Gerrit 2.8.3 to Gerrit 2.9 (via 2.9.rc2) and suddenly our code 
reviews were blocked waiting for a verify step. We found that Gerrit had added 
an extra label that wasn't there in 2.8 and might be a regression.

Author: Gerrit Initialization <init@gerrit>
Date:   Mon Jul 21 09:30:09 2014 +0100

    Configure 'Verified' label

+[label "Verified"]
+       function = MaxWithBlock
+       value = -1 Fails
+       value =  0 No score
+       value = +1 Verified

Note that we were on 2.9.rc2 for some time testing interaction with its-jira 
which appeared fine. After upgrading however its-jira stopped working which may 
be related as the very next commit in the All-Projects history was todo with 
jira initialisation 

 [plugin "its-jira"]
        enabled = true
+       branch = refs/heads/*
 [label "Verified"]
        function = MaxWithBlock
        value = -1 Fails
-       value =  0 No score
+       value = 0 No score
        value = +1 Verified

Original issue reported on code.google.com by berthami...@gmail.com on 26 Jul 2014 at 5:59

GoogleCodeExporter commented 9 years ago 
It works as expected. During init phase (in your case during upgrade phase) 
there is InitStep that installs Verify label. Apparently you have answered the 
question for 'Y'. That why you see the commit n refs/meta/config branch. If you 
don't want Verify label, just remove [label "Verified"] section from 
project.config.

Original comment by David.Os...@gmail.com on 28 Jul 2014 at 2:55

GoogleCodeExporter commented 9 years ago 
I've faced similar problem, folks.
Yesterday I've upgraded gerrit from 2.8.5 to 2.9. IIRC installer didn't ask me 
about installing labels.
Now that's the issue: user cannot submit a change.
On Change Screen I see 
  - "Change NNN - Needs Verified" at the top-left
  - "Code-Review +2 Verified" below the right pane
  - no UI to verify (because no one has permission on Label Verified)

First I added permission on Label Verified (to make users happy), then removed 
that label at all (to make them very happy:)).

All's well that ends well.
That's it

Original comment by Jonh.Kel...@gmail.com on 2 Sep 2014 at 1:08