CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

Prolog Cookbook: Describe better how to inherit submit rules #3189

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.10

What steps will reproduce the problem?
1. Create a rules.pl file in All-Projects.git
2. See that it does not get run in projects that inherit All-Projects.git

What is the expected output? What do you see instead?

It's not clear from the documentation 
(https://gerrit-review.googlesource.com/Documentation/prolog-cookbook.html) 
that rules.pl does not get inherited as project.config does.

I think that projects should inherit rules.pl from their parents in the same 
way that they inherit project.config (this would be easier to manage, and seems 
more intuitive to me).

If that's not possible, it should be clear in the documentation that they don't 
inherit.

Please provide any additional information below.

Original issue reported on code.google.com by cam.sp...@solidfire.com on 18 Feb 2015 at 11:39

GoogleCodeExporter commented 9 years ago
Submit rules apply only to the current project, if you want inheritance you 
must implement a submit filter as described in [1].

[1] 
https://gerrit-review.googlesource.com/Documentation/prolog-cookbook.html#Submit
Filter

Original comment by edwin.ke...@gmail.com on 19 Feb 2015 at 7:50

GoogleCodeExporter commented 9 years ago
I see, thank you!

I still think that this could be more clear in the documentation though, should 
I try to open a new issue/request on that or could this issue be used to track 
that?

Original comment by cam.sp...@solidfire.com on 19 Feb 2015 at 4:49

GoogleCodeExporter commented 9 years ago
We can use this issue, I've adapted the issue summary.

Original comment by edwin.ke...@gmail.com on 20 Feb 2015 at 7:07