CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

WIP Plugin: draft access control affects wip changes (may cause confusion) #3269

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The WIP plugin binds to the draft access control (view draft, publish draft, 
delete draft) which isn't a bad thing but it might be confusing to users.  I'm 
not sure how these should change when using the wip plugin.  I could think of a 
few different ways to handle this:
 1. change the existing ACL names from 'draft' to 'wip'. 
 2. don't make any changes to the existing set of ACLs, just add a new wip ACLs (view wip, update wip).
 3. Just provide documentation to configure access to wip changes using the 'draft' ACLs

Since some users may change from using draft to using WIP with existing data, 
#2 might the better option since it won't mess up their existing changes.  Or 
maybe just do #3 since it's the easiest.

Original issue reported on code.google.com by zaro0508 on 31 Mar 2015 at 10:37

GoogleCodeExporter commented 9 years ago
Here's a change for option #3: https://gerrit-review.googlesource.com/#/c/66790/

Original comment by zaro0508 on 31 Mar 2015 at 10:44