CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

Submit Button is very confusing #3383

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When performing a peer review. A comrade of mine had recently typed submit 
after adding some notes. He unknowingly then pushed to code to the remote (or 
as we call it... Brahma) causing a huge fuss. Could you please change this to 
something like "Push to Remote", "Push" or "Approve and Push". 

Thank you

Original issue reported on code.google.com by Dustin.D...@gmail.com on 20 May 2015 at 9:47

GoogleCodeExporter commented 9 years ago
I think the names that you propose are not suitable. When you click on submit 
there is no interaction with a remote repository and also no git push operation 
is performed. What happens on submit depends on the submit type of the project, 
it may be a merge, rebase or cherry-pick inside of the repository on Gerrit. 
Still if you don't like the label, you can reconfigure it [1] and also change 
the tooltip [2].

[1] 
https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#change.s
ubmitLabel
[2] 
https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#change.s
ubmitTooltip

Original comment by edwin.ke...@gmail.com on 21 May 2015 at 5:45