CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

Reviewers plugin UI is broken due to mis-generated links in Gerrit 2.11 #3400

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version:
Gerrit 2.11 with reviewers plugin from stable-2.11 branch

What steps will reproduce the problem?
1. Create a project with "/" in name, e.g. "aa/bb"
2. Try clicking on Reviewers tab in project screen
In the reverse proxy config "AllowEncodedSlashes On" is already configured.

What is the expected output? What do you see instead?
The reviewers plugin UI should be opened, but instead you get:

"Code Review - Error
The page you requested was not found, or you do not have permission to view 
this page."

Please provide any additional information below.

The generated link for Reviewers plugin web UI is:
https://<Gerrit Instance URL>/#/x/reviewers/aa%2Fbb
 instead of 
https://<Gerrit Instance URL>/#/x/reviewers/aa/Fbb 

This used to work correctly in Gerrit 2.10. It looks like this is a regression 
in Gerrit 2.11 in the way plugins contribute links in project context with 
project names including "/".

Original issue reported on code.google.com by bassem.rabil on 29 May 2015 at 5:50

GoogleCodeExporter commented 9 years ago

Original comment by David.Os...@gmail.com on 31 May 2015 at 7:45

GoogleCodeExporter commented 9 years ago
@Edwin, this regression was caused by this commit: [1]. Can you have a look?

* [1] 
https://github.com/gerrit-review/gerrit/commit/f2d4c991f675805acf6011481df670717
1e907c3

Original comment by David.Os...@gmail.com on 2 Jun 2015 at 6:17

GoogleCodeExporter commented 9 years ago
It is correct that the project name is encoded in the URL
  https://<Gerrit Instance URL>/#/x/reviewers/aa%2Fbb

The Reviewers plugin should decode it.

Original comment by edwin.ke...@gmail.com on 2 Jun 2015 at 7:36

GoogleCodeExporter commented 9 years ago
https://gerrit-review.googlesource.com/68280

Original comment by edwin.ke...@gmail.com on 2 Jun 2015 at 7:40

GoogleCodeExporter commented 9 years ago
The fix was moved to stable-2.11:
  https://gerrit-review.googlesource.com/68281

Original comment by edwin.ke...@gmail.com on 2 Jun 2015 at 8:04

GoogleCodeExporter commented 9 years ago
fixed in stable-2.11 branch

Original comment by huga...@gmail.com on 2 Jun 2015 at 1:02