CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

Error when viewing large diffs using the new screen #3432

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
View large changes with new screen causes a string index out of range error.   
Does not happen using old screen, only repros on new screen.

Affected Version: 2.10.5 with new screen

What steps will reproduce the problem?
1. upload a change with a big diff (hundreds of large files with many line 
changes). Something similar to this https://review-dev.openstack.org/#/c/5354 
which has ~700 files, ~2000 lines of diff.
2. Make sure your profile is set to using the new screen.
3. View some of the files in the change. 

What is the expected output? What do you see instead?
I would expect the diffs to be viewable, however a '500 Server Error' appears.  
The logs [1] says 'java.lang.StringIndexOutOfBoundsException: String index out 
of range'.  Viewing small changes on the same project continues to work fine 
even after this error occurs.

Please provide any additional information below.
When viewing this same change using the old screen it seems to work fine as 
long as it doesn't exceed the diff timeout which seems like a related but 
different bug [2].  I tried increasing the 'cache "diff"' and 'cache 
"diff_interaline"' to 5m in gerrit.config but that didn't make any difference.

[1] http://paste.openstack.org/show/290965/
[2] https://code.google.com/p/gerrit/issues/detail?id=3424

Original issue reported on code.google.com by zaro0508 on 14 Jun 2015 at 2:57