Include previous approvals in the approvals table

[GoogleCodeExporter]

On my team we occasionally +2 our own patch sets if they've already received a 
+2 review. Usually this happens when the code's author is asked to make a 
trivial change (whitespace etc.) before submit.

When reviewing such a change in gerrit, it's not obvious at a glance whether a 
change ever received a +2. You have to read through the comments.

I'd like it if gerrit included the history of +2s and other grades in the 
overview table. I've attached a screenshot to make this concrete, although I 
don't really care too much how it looks in the UI.

Original issue reported on code.google.com by jessewil...@google.com on 17 Sep 2010 at 5:02

Attachments:

• gerrit-mockup.png

[GoogleCodeExporter]

An alternative layout would keep one column, but include a greyed-out checkmark 
with the patch set that it applies to:

  Reviewer         Code Review
  Brian Carlstrom  ✓
  Elliott Hughes   ✓ (PS2)
  Jesse Wilson

Original comment by jessewil...@google.com on 17 Sep 2010 at 5:05

[GoogleCodeExporter]

Related to this, the approvals end up getting appended to the commit email, and 
it would be nice if the prior approvals show up there as well, for the same 
reasons.

Original comment by danf...@google.com on 27 Sep 2010 at 11:55

[GoogleCodeExporter]

Original comment by nas...@grainawi.org on 21 May 2011 at 12:37

• Changed state: Accepted