search

Cangjians / ibus-cangjie

An IBus engine for users of the Cangjie and Quick input methods
30 stars 14 forks source link

Skipping the Gtk test fails #56

Closed bochecha closed 9 years ago

bochecha commented 10 years ago

It seems the behaviour of importing Gtk changed between Ubuntu 12.04 (our CI server) and Fedora 20+.

So the detection we have in our unit tests (can we import Gtk? if no slkip the test) fails on recent Fedora, which makes the unit tests fail.

We need to fix this.

bochecha commented 10 years ago

For now, I'm using this patch in Fedora: https://pkgs.fedoraproject.org/cgit/ibus-cangjie.git/tree/ibus-cangjie-2.2-Skip-a-unit-test.patch

It unconditionally skips the unit test.

Obviously, that's not an acceptable patch upstream, we want to be able to skip the test only when in a non-graphical environment (build for distros, CI,...), but keep it for our development workstations.

yookoala commented 10 years ago

Does that means we cannot support both Fedora 20+ and 12.04 at the same time?

bochecha commented 10 years ago

For users, we absolutely can, no problem at all.

The problem is in the unit tests, not in the code that the user runs.