search

CanisLupus / swift-selection-search

Swift Selection Search (SSS) is a simple Firefox add-on that lets you quickly search for some text in a page using your favorite search engines.
https://addons.mozilla.org/firefox/addon/swift-selection-search/
MIT License
216 stars 26 forks source link

Enhance requests & proposals #16

Open yfdyh000 opened 7 years ago

yfdyh000 commented 7 years ago

Enhance requests:

  1. Localization support (l10n).
  2. Animation option, including more effects (minor; like Beyond Australis) and None (to reduce the sense of vertigo, because each zoom and popup).

Enhance proposals:

  1. Options page, avoids cumbersome and large margins in the Add-ons Manager.
  2. A manager for popup icons, if the user has installed many search engines. Even gridding and sorting, like Drag & DropZones extension.
  3. Avoid enlarging icons and padding instead, if the installed search engine has a small icon (16x16px). Like this (it is an old installation): screenshot
CanisLupus commented 7 years ago

Hi there, I wrote your suggestions down. :)

  1. The hard thing about localization is that from the point where things are translated onward, any text change, no matter how small, will incur in great overhead to fix all the translations. :) It's a good suggestion, and I will likely consider it when I feel that I've done most of the things I want to do with SSS.

  2. Just noting that SSS has an option to reduce the animation duration to 0ms to completely avoid waiting. That said, there are no options yet to customize animations. :P

  3. Yes. That was already considered. I also dislike the massive space waste in the add-on page. Changing SSS from a jetpack SDK thing to a WebExtension would be a good reason to change that.

  4. Will consider that. :) A way to reorder the engines and copy/link icons is also already written down.

  5. Could you elaborate on this, please? Is it the icon quality, for example that pixelated Wikipedia one? I simply use the icons as they are in Firefox itself, so there's unfortunately not much I can do about that. Do you mean to add padding instead of enlarging the icon if it is too small?

Gitoffthelawn commented 7 years ago
  1. The copy and open in tab icons are a bit pixelated due to the scaling from the original. Was distracting the first few uses... now used to it and kind of like it because it makes the icons a bit "softer", which differentiates them from the other icons. Could go either way on making those non-pixelated.
CanisLupus commented 7 years ago

Hmm don't know what I can do about those. :p I left the copy and open link icons as SVGs (I made them myself) instead of rasterized images (ex.: png), so they can scale to whatever needed size without losing quality. Maybe because they are small on the panel, the browser's image scaling blurs them a bit. I didn't see that happen on my Firefox, but it can happen. If I transform them to PNGs they WILL definitely lose quality if someone zooms in or sets the icon size to bigger than normal in the options.

Gitoffthelawn commented 7 years ago

I was going to suggest SVGs, but I see you are one step ahead of me! The only thing would be to simplify them a little, but I doubt it's worth the effort.

I had actually hacked together an open url feature, and used the same icon you chose. I used it at 100% size, and it was clear. But you are using it a little smaller, and I like that because it results in visual distinction. If you want to add a scaling option in the settings for the copy to clipboard and open url items, people can play with the scaling that works best for them.

CanisLupus commented 7 years ago

If you are okay with how they look, I will prefer to see if someone else has issues. I thought I would avoid this by using SVG but I guess not everything is perfect even so. :)

By the way, my icon is not the same as yours. :) But I did base it closely off of one icon so you might be using that. I remade it myself to avoid licensing issues, mostly. The copy icon too.

Gitoffthelawn commented 7 years ago

Sounds good!