CanisLupus / swift-selection-search

Swift Selection Search (SSS) is a simple Firefox add-on that lets you quickly search for some text in a page using your favorite search engines.
https://addons.mozilla.org/firefox/addon/swift-selection-search/
MIT License
215 stars 26 forks source link

Add an Append to Clipboard button #167

Open Mike-Reddick opened 4 years ago

Mike-Reddick commented 4 years ago

Please Add an Append to Clipboard button, like the "copy" button but to append and add an new button in the front of the popup text box to put appended text into text box for instance:

Word 1 bla bla bla bla bla bla Word 2 bla bla bla bla bla bla bla Word 3

I can select Word 1 append it, after I append Word 2, after I can select Word 3 (this word I not append, just select), then in the textbox show :

Word 3

if I click on the text box button "add clipboard content" then show in text box:

Word 3 Word 1 Word 2

CanisLupus commented 4 years ago

Hello and thanks for the suggestion! I'll consider this. The "append to clipboard" is something that I think was asked previously by someone, but the "append to text box" was definitely not.

When appending to the clipboard, this would simply append to the text previously copied in SSS (either via copy or append) and not to the text currently on the clipboard (for example from other apps), otherwise SSS will need a new permission that some users will find scary (read from clipboard).

Mike-Reddick commented 4 years ago

I think which just one unified clipboard can be better to the user, to avoid some confusion because of "two clipboards", I have no problem with this new permission, but I understand you, if you think this can be an issue, so implement this separated clipboard. Maybe possible an setting to choose the behavior? I don't know if firefox support permission by demand?! Thank you !

CanisLupus commented 4 years ago

Yes, asking for a permission only when it is needed for the first time is possible in Firefox. In that case it would have to be requested when the user enables the append button(s) somewhere in the options page. I guess this will have to be seen in more detail later. :)

Mike-Reddick commented 4 years ago

it would have to be requested when the user enables the append button(s) somewhere in the options page

Perfect!