search

CanisLupus / swift-selection-search

Swift Selection Search (SSS) is a simple Firefox add-on that lets you quickly search for some text in a page using your favorite search engines.
https://addons.mozilla.org/firefox/addon/swift-selection-search/
MIT License
215 stars 26 forks source link

Auto popup doesn't often work after updated to v.3.42.0 #187

Closed Thomasc5 closed 4 years ago

Thomasc5 commented 4 years ago

After SSS for Firefox is updated to v. 3.42.0, auto popup (i.e. open on text selection) doesn't work intermittently. Reload the page will solve the problem.

How to reproduce the problem

  1. Go to any website (e.g. Wikipedia)
  2. Middle click 5-6 links successively and let them load in the background
  3. Highlight text: auto popup wouldn't work on some pages
  4. Press F5 to reload those pages will make SSS auto popup on text selection work again

Anything else you'd like to include Earlier SSS versions (e.g. v. 3.41.2) do not have this problem

System info:

Thank you

CanisLupus commented 4 years ago

Hi @Thomasc5 I must be really quick in this reply but I thank you very much for reporting this issue. I've made a very quick fix and submitted version 3.42.1 to Mozilla. I don't know when it will be live but it should fix this problem. Sorry for this! Later today I'll have more time.

Cheers! Daniel

CanisLupus commented 4 years ago

So, I'm in less of a rush now. :) It also seems the version is live now.

The issue was due to a change I made for the website blocklist feature. The code was always registering the addon's page script with the currently active tab instead of the actual just-opened tab (I hadn't noticed), so tabs opening in the background didn't get the popup. I tested this but apparently I didn't use background tabs for the test.

I'm leaving this issue open for a while for people to see it immediately (if they come here) until they get the update. Please let me know if you find additional problems.

CanisLupus commented 4 years ago

I'm closing this now since I heard of no other issues in the meantime.