search

CanisLupus / swift-selection-search

Swift Selection Search (SSS) is a simple Firefox add-on that lets you quickly search for some text in a page using your favorite search engines.
https://addons.mozilla.org/firefox/addon/swift-selection-search/
MIT License
213 stars 27 forks source link

Incorrect favicons from api.faviconkit.com #221

Closed Slevest closed 3 years ago

Slevest commented 3 years ago

For example: https://api.faviconkit.com/sinonim.org/64 https://api.faviconkit.com/rutracker.org/64 Correct: https://icons.duckduckgo.com/ip3/sinonim.org.ico https://icons.duckduckgo.com/ip3/rutracker.org.ico

CanisLupus commented 3 years ago

Hi Slevest, if these icons are wrong it would be an issue with faviconkit, so could you report it to them? SSS is unrelated to faviconkit and already provides a way for the user to replace the icon URL with something else, so I don't think there's anything else I can do here. :)

Slevest commented 3 years ago

How can I load icons from folders on my computer?

CanisLupus commented 3 years ago

Normally, you'd add it using an icon URL like file:///C:/Some/Folder/image.png. However, images from your computer get blocked from showing on web pages for security reasons, otherwise the JavaScript in the site could access them, so they won't show up in the SSS popup OR the options page. They do work on the context menu, though.

So in general you can't. :| You could upload your icons to some image service and then use the public link they provide, however.

I hope this helps. I'll close this issue since this was a problem with faviconkit.