Canna71 / obsidian-chronology

Other
100 stars 7 forks source link

[Bug][minor] The ribbon icon doesn't disappear if disabled in settings. Reload or restart is required. #2

Closed SebastianMC closed 1 year ago

SebastianMC commented 1 year ago

By default the ribbon icon is enabled after installation of the plugin. Going to settings and disabling it via the 'Add Ribbon Icon' doesn't hide the icon automatically. The user has to either restart or reload Obsidian (or the vault) or disable and re-enable the plugin to apply the setting. Same behavior the other way round: after enabling 'Add Ribbon Icon' need to reload/restart/... to actually show the icon.

Let the ribbon icon immediately reflect the actual setting, it is a standard behavior observed for core plugins and amongst community plugins as well.

This is minor, fix should be easy

Nice plugin, thanks!!!

Canna71 commented 1 year ago

Thank you, will do ASAP!

On Fri, Sep 30, 2022 at 10:57 AM SebastianMC @.***> wrote:

By default the ribbon icon is enabled after installation of the plugin. Going to settings and disabling it via the 'Add Ribbon Icon' doesn't hide the icon automatically. The user has to either restart or reload Obsidian (or the vault) or disable and re-enable the plugin to apply the setting. Same behavior the other way round: after enabling 'Add Ribbon Icon' need to reload/restart/... to actually show the icon.

Let the ribbon icon immediately reflect the actual setting, - it is standard behavior observed for core plugins and amongst community plugins as well.

This is minor, fix should be easy

Nice plugin, thanks!!!

— Reply to this email directly, view it on GitHub https://github.com/Canna71/obsidian-chronology/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIOYB4VZX73XC7B2ABH2ADWA2TRJANCNFSM6AAAAAAQZSE56A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Gabriele Cannata

Canna71 commented 1 year ago

Done 1n 1.0.1

SebastianMC commented 1 year ago

Excellent!