Canna71 / obsidian-janitor

Performs various maintenance tasks on the Obsidian vault
Other
96 stars 5 forks source link

There is no confirmation dialog #10

Open merlinuwe opened 1 year ago

merlinuwe commented 1 year ago

I installed your plugin today and can get it run.

image

But it does not end running ... and there comes no confimation dialog, even not after 1 hour.

The settings are set to default.

What can I do?

Windows 10, lastest updates Obsidian 1.0.3

Canna71 commented 1 year ago

Hi, could you please open the Developer Console to see if there is any error? Thanks a lot.

mikebarkmin commented 1 year ago

For me, the error came from an invalid regex expression. I fixed the expression and now everything works fine again.

Canna71 commented 1 year ago

@mikebarkmin could you elaborate? you mean the regex you can insert for excluding files or folders?

mikebarkmin commented 1 year ago

That's correct. My first attempt was *.excalidraw, but this is an invalid regular expression and lead to the error. .*.excalidraw is the correct one.

Canna71 commented 1 year ago

I see, I could try and add a validator. Thank you for reporting this.

Canna71 commented 1 year ago

Added a Regex Validator 1.0.7

merlinuwe commented 1 year ago

Thank you very much. I also had to delete a wrong excluded file (.xlsx) to get it work. Thanks to @mikebarkmin for the example and for you for implementing the validator.

Can you please give some regex examples for janitor excluded files in your documentation? (files in folder x younger/older than yyy-mm-dd, files that start or end with some letters, files with dates in their name, AND and OR, ...)

Canna71 commented 1 year ago

Thank you both, I will try to improve documentation!

MossabDiae commented 1 year ago

Sorry for replying to an old issue but came here to manually exclude canvas files as they were deleted by Janitor, here's a reference for future members.

The correct syntax is: .*.canvas

@Canna71 can you kindly consider excluding them by default, I think most of the time they are used as orphans.