Canner / WrenAI

🚀 Open-source SQL AI Agent for Text-to-SQL. Make Text2SQL Easy! 🙌
https://getwren.ai/oss
GNU Affero General Public License v3.0
1.73k stars 155 forks source link

wren-launcher is incompatible with headless linux #640

Closed tikimo closed 3 weeks ago

tikimo commented 3 weeks ago

The commands used check for Docker Desktop, which is not in my understanding a requirement.

This prevents the launcher from utilizing a headless Docker installation (Docker CLI) as it keeps looking for the docker-desktop. Docker desktop requires KVM, which is not available on all hosts.

https://github.com/Canner/WrenAI/blob/2d13dddc3c4b146ea2f3afa3b7fe723b834a0b40/wren-launcher/utils/docker.go#L97

tikimo commented 3 weeks ago

Case:

tikimo commented 3 weeks ago
INFO  Checking if Docker daemon is running
INFO  Docker daemon is not running, opening Docker Desktop
ERROR   An error occurred: exit status 5
cyyeh commented 3 weeks ago

@tikimo thanks for reaching out!

https://github.com/Canner/WrenAI/blob/2d13dddc3c4b146ea2f3afa3b7fe723b834a0b40/wren-launcher/utils/os.go#L57 how about changing the line to "systemctl", "--user", "start", "docker"?

Does that work to you?

tikimo commented 3 weeks ago

works!