Canner / WrenAI

πŸš€ Open-source SQL AI Agent for Text-to-SQL. Make Text2SQL Easy! πŸ™Œ
https://getwren.ai/oss
GNU Affero General Public License v3.0
1.76k stars 161 forks source link

The data source connection password is empty #712

Open fredalai opened 1 day ago

fredalai commented 1 day ago

Describe the bug

When viewing the Data Source Settings page for a connected MySQL data source, the password field appears empty.

To Reproduce

Steps to reproduce the behavior:

  1. Connect MySQL data source
  2. Go to the Home / Modeling page
  3. Click "Settings" below the sidebar to view the Data Source Settings
  4. See the password field is empty

Expected behavior

Show password placeholder ************ instead of empty when viewing the Data Source Settings.

Screenshots

ζˆͺεœ– 2024-10-03 δΈ‹εˆ2 47 57

Root cause

The Backend API will not return the password field information, so it will become empty if the front end does not process it.

Solution

swarupn17 commented 17 hours ago

Hello @fredalai ! I think i can do this task please can you assign it to me. Thanks.

cubsg commented 8 hours ago

Hi, I've added changes to the MySQLProperties.tsx file. I edited line 76, replacing the password placeholder from "input password" to "****".

chilijung commented 7 hours ago

@swarupn17, it looks like @cubsg has been working on this issue and also submitted a PR. Can you look into other issues that you might be interested in? Thanks!