search

CannibalVox / DimDoors

Other
44 stars 28 forks source link

Incorrect lighting in sub-personal-dimension on server restart #18

Closed chaoskagami closed 9 years ago

chaoskagami commented 9 years ago

Time for another report. Steps to reproduce: Place personal dimensional door. Enter. Place dimensional door. Enter. Logout, restart server, log in. Result looks like this when it should be 100% white like previous. Also, my client minimap seems to show the dimension with a black outer color on reload vs white:

2015-03-20_18 00 58

Again, like the previous issue I reported, this only occurs on a server. Not on a client opened to LAN. There's also nothing in the log for this one since it's rendering-related. This has been tested sans every other mod as well, so feel free to ignore the other stuff in my inventory.

EDIT: Also, running on test8. Forgot that.

P3rf3ctXZer0 commented 9 years ago

I will see if I can verify this bug. Lol we both have cat avatars :D

CannibalVox commented 9 years ago

Looks like a bug that used to happen where the personal was sometimes using the basic pocket provider client-side, causing the lighting to be jacked up. I'll investigate this.

chaoskagami commented 9 years ago

It only seems to happen on a server, and only specifically in secondary personal dimensions. The main one is always lit correctly after a server restart. It also lights correctly until a server restart, including client connect and disconnect, entering, exiting, etc.

Anyways, it's only visual. It's not going to eat my world. Lower priority, I'd say.

chaoskagami commented 9 years ago

If investigation of this isn't going anywhere, mind if I have a look on my end? If I can figure it out, I'll submit a pull request with a fix.

I have a lot of time, anyways.

CannibalVox commented 9 years ago

Hi, I'm trying to understand this bug- when I place a personal door inside my personal dimension, the door sends me to limbo, which is what's supposed to happen. Is that not the case for you?

chaoskagami commented 9 years ago

This bug has nothing to do with personal doors in personal dimensions. That works correct - you get sent to limbo.

I'm talking about placing normal dimensional doors in personal dimensions. It is completely fine with colors, unless running a server and the server is restarted. After which the dimension takes on the odd lighting in the screenshot.

This only happens in a forge server. It doesn't happen with singleplayer or open-to-LAN. I couldn't figure out what was causing it, and I'm unsure if it still happens. I can test it again, if you'd like.

EDIT: For more clarity, placing a dimensional door in a personal dimension creates another 100% white dimension linked to the personal dimension, so it ends up rather like a sub-personal-dimension. On a server restart, lighting is black like a normal dimensional door placed anywhere in the overworld, but the blocks are still the white blocks of a personal dimension. They appear to put out light, which causes this odd lighting issue. Beyond that, it's possible the server isn't restoring the colors correctly on servers for some reason. Why, I am not sure.