CanonicalLtd / UCWifiConnect

The code of this project has been moved to https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/wifi-connect
GNU General Public License v3.0
2 stars 2 forks source link

Cli cleanup #34

Closed knitzsche closed 7 years ago

knitzsche commented 7 years ago

refactor cli to a single command with no flags. And add manual mode in which deamon loop is pausable with a clean restart.

sudo 'wifi-connect.cli stop' pauses daemon in current state. Then 'sudo wifi-connect start'.

Removed netplan code in favor of README instructions to set all interfaces to be managed by NetworkManager, since network-manager snap will provide a config to do this step later.

knitzsche commented 7 years ago

FYI Roberto, I think master is ahead by one commit, but it is a README.md change that I made and that I do not want anymore.

rmescandon commented 7 years ago

Approved. This works much better now. Only one thing is still rounding my head and we talked briefly about it, but still is there in my mind: shouldn't be enough stopping the service instead of having a stop command?. I mean. I don't see the advantage of having the daemon looping doing nothing when calling stop. Is that related with maintaining a status when user executes hidden commands to know where we are if back to normal state? In any case. Anything to be changed related to this, in another PR

knitzsche commented 7 years ago

I chose this stop mechanism to allow the user to stop wifi-connect from controlling state in a way that persists through reboots. Stopping the daemon service would not persist through a reboot. So current stop mechanism allows user to stop it persistently without having to uninstall.