search

Canop / broot

A new way to see and navigate directory trees : https://dystroy.org/broot
MIT License
10.33k stars 225 forks source link

Pressing `right` to open file leaves a `xdg-open` zombie process #801

Open jinliu opened 7 months ago

jinliu commented 7 months ago

STEPS TO REPRODUCE:

  1. broot
  2. Press right on a file
  3. htop --tree

OBSERVED: xdg-open zombie under broot

Canop commented 7 months ago

Precision: this process disappears when broot is closed.

Broot doesn't call xdg-open directly but through the opener crate (https://github.com/Seeker14491/opener) It would be interesting to check whether the problem is in the opener crate or if broot misuses it.

And whether it happens with similar crates too (eg the open crate).

jinliu commented 7 months ago

Seems indeed a problem in that crate: https://github.com/Seeker14491/opener/blob/ff6e2599f1360332dac2b87877f9e1694ad654c3/opener/src/linux_and_more.rs#L53 Note the return value of open_with_system_xdg_open is dropped.