search

Canop / broot

A new way to see and navigate directory trees : https://dystroy.org/broot
MIT License
10.39k stars 226 forks source link

For a symlink to another partition, opening it in a new panel shows a wrong fs size #804

Closed jinliu closed 8 months ago

jinliu commented 8 months ago

STEPS TO REPRODUCE:

  1. Create a symlink to a dir in another partition.
  2. broot --show-root-fs
  3. Press right on that link.
  4. The fs size on the header bar updates correctly.
  5. Press left to go back.
  6. Press Ctrl+right to open the symlink in a new panel.
  7. The fs size in the new panel is still that of the left panel.
jinliu commented 8 months ago

Perhaps one solution is to make ctrl-right behave like right: the current directory is set to the target of the symlink, not the symlink itself. More consistency.

Canop commented 8 months ago

I reproduce the problem. I'll have a look.

Canop commented 8 months ago

It should be fixed by https://github.com/Canop/broot/pull/805

jinliu commented 8 months ago

Yes, it works. Thanks!

Canop commented 8 months ago

BTW I'll push another change, I think: removing the filter when doing :panel_right on a directory

alexn-s commented 7 months ago

i think this fix or at least version 1.30.0 > breaks something on windows @Canop . the right/ second panel is broken and commands like cpp and mvp wont work.

the path is not correct

version 1.30.0, 1.30.1

image

version 1.29.0

image

sys info

OS: Windows 11 Home x86_64 Terminal: Windows Terminal shell: nushell

let me know if i can provide more information