Canop / dysk

A linux utility to get information on filesystems, like df but better
https://dystroy.org/dysk
MIT License
890 stars 25 forks source link

improvement - Show duplicate mounts #52

Open daniejstriata opened 2 years ago

daniejstriata commented 2 years ago

Will it be possible for lfs to highlight duplicated mounts?

┌────────────────────────────┬────┬────┬─────┬─────────┬─────┬─────┬──────────────────┐
│         filesystem         │type│disk│used │   use   │free │size │mount point       │
├────────────────────────────┼────┼────┼─────┼─────────┼─────┼─────┼──────────────────┤
│/dev/nvme0n1p2              │xfs │SSD │ 26Gi│26% █▍   │ 74Gi│100Gi│/                 │
│/dev/nvme7n1p1              │xfs │SSD │ 17Gi│66% ███▍ │8.4Gi│ 25Gi│/var/Data         │
│/dev/mapper/vg1-LVvarStriata│ext4│LVM │ 17Gi│66% ███▍ │8.4Gi│ 25Gi│/var/Data         │
│/dev/nvme8n1p1              │xfs │SSD │8.4Gi│56% ██▊  │6.6Gi│ 15Gi│/usr/local/App    │
│/dev/nvme4n1p1              │xfs │SSD │216Mi│ 2% ▏    │ 11Gi│ 11Gi│/var/App-local    │
│/dev/nvme1n1                │xfs │SSD │1.6Gi│32% █▋   │3.4Gi│5.0Gi│/home             │
│/dev/nvme6n1p1              │xfs │SSD │1.0Gi│34% █▊   │2.0Gi│3.0Gi│/var/log          │
│/dev/nvme3n1                │xfs │SSD │372Mi│18% ▉    │1.6Gi│2.0Gi│/tmp              │
└────────────────────────────┴────┴────┴─────┴─────────┴─────┴─────┴──────────────────┘

Somehow the old mount was not removed in the fstab and seems that both were mounted at the same time with the second one taking priority.

Canop commented 2 years ago

I'd accept other opinons but right now I wouldn't do that:

There are valid reasons to have two filesystems hooked to the same mount-point.

More generally it's very difficult to analyze and detect that a configuration is invalid. And detecting only one (or a few) strange cases isn't really going to help IMO.

daniejstriata commented 2 years ago

I was not thinking to show invalid config. Just to pair same mounts points by colour or bold.