Canop / miaou

A chat server with OAuth2 authentication, persistent and searchable history, video and audio, markdown formatting, private and public rooms, stars, votes, embedded games, and many other features
http://miaou.dystroy.org/
Other
542 stars 73 forks source link

Return focus to text field after pressing Send #4

Closed MadaraUchiha closed 10 years ago

MadaraUchiha commented 10 years ago

When I type a message from mobile and hit Send, focus should be returned to the input so that the mobile keyboard doesn't go away.

Canop commented 10 years ago

I disagree. I did it, but for the non mobile version. On mobile, I don't want the virtual keyboard to remain open. A user isn't supposed to post many small messages.

But I might add a button to insert new lines (you can't do ctrl-enter on mobiles) so that a user can easily send multi-lines messages.

Notes : this request remains open, so that people may comment (and maybe change my mind).

MadaraUchiha commented 10 years ago

Well, what's the difference between hitting the send button and hitting Enter in terms of "many small messages"?

If you want to throttle, throttle or limit users from posting consecutively. But UX shouldn't be harmed.

The Send Button and the Enter key (if they both send) should have exactly the same functionality.

On Sun, Jan 26, 2014 at 6:31 PM, Canop notifications@github.com wrote:

I disagree. I did it, but for the non mobile version. On mobile, I don't want the virtual keyboard to remain open. A user isn't supposed to post many small messages.

But I might add a button to insert new lines (you can't do ctrl-enter on mobiles).

Notes : this request remains open, so that people may comment (and maybe change my mind).

— Reply to this email directly or view it on GitHubhttps://github.com/Canop/miaou/issues/4#issuecomment-33320973 .

Canop commented 10 years ago

Why do you want the virtual keyboard to remain open and the input focused ?

In my opinion (for now), if you want to send many messages fast, it's because you should send one multi-line message but it's hard on mobile.

BTW, the send button and the Enter key do have exactly the same functionnality.

MadaraUchiha commented 10 years ago

No they don't. When hitting Enter, focus remains in the input box. That functionality should port to the Send as well, or removed altogether. But I think it makes sense to keep the keyboard open, not just to send many messages in a row, but to not break the visual link. (Think you're reading something, and suddenly the page scrolls).

On Sun, Jan 26, 2014 at 6:36 PM, Canop notifications@github.com wrote:

Why do you want the virtual keyboard to remain open and the input focused ?

In my opinion (for now), if you want to send many messages fast, it's because you should send one multi-line message but it's hard on mobile.

BTW, the send button and the Enter key do have exactly the same functionnality.

— Reply to this email directly or view it on GitHubhttps://github.com/Canop/miaou/issues/4#issuecomment-33321075 .