search

Canop / termimad

A library to display rich (Markdown) snippets and texts in a rust terminal application
MIT License
914 stars 31 forks source link

"coloor" dependency introduces LGPL-3.0 #51

Closed matthiasbeyer closed 1 year ago

matthiasbeyer commented 1 year ago

First of all: I am not a lawyer.

With that out of the way: The coloor dependency depends (since its 0.6.0 release) on a crate that is LGPL-3.0.

To my understanding, that means that the coloor crate is LGPL-3.0 itself, because of static linking and LGPL is only "lesser" for non-static linking, is it not? That would mean that termimad is LGPL-3.0 since the introduction of the coloor dependency as well.

I found that because CI broke here: https://github.com/TheNeikos/type_description/pull/265 (job).

Canop commented 1 year ago

Damn. And I had scrapped my alternate implementation of the function I use in ansi_colours, just to make one thing less to maintain, I don't think I even kept the branch...

EDIT: I had kept the branch. I'll see if it's good enough.

I'll remove the ansi_colours dependency when I can, but if you (or somebody else) find or write (either separately or in coolor itself) the necessary function, it would help me.

matthiasbeyer commented 1 year ago

You seem not to use any github actions, why is that? I just wanted to add a cargo-deny job, which would have found the issue before it was introduced,... but found that there are no actions at all and wondered why that is?

Canop commented 1 year ago

I use some of them, sometimes, depending on the project. But I removed most of them because they're so slow and because they mostly catch problems I'd rather catch locally instead of pushing commits for that (I'm the author of almost all the commits on my projects).

A GH action catching licence problems looks useful, though. I'd probably accept a PR for that.

Canop commented 1 year ago

coolor 0.8 removes the dependency to ansi_colours: https://github.com/Canop/coolor/commit/4fb511640a9c71765ddd5d125b7c5866f8935883