search

CanopusFalling / recycle-extension

Chrome extension to allow users to determine if a product is recyclable or not.
MIT License
2 stars 0 forks source link

Permissions Overhaul #20

Closed CanopusFalling closed 3 years ago

CanopusFalling commented 3 years ago

The current permissions are a mess and probably need to be cleaned up, possibly search for a way to not use the host permission given how permissive it is.

Also needs to be a section in the README with proper permission justification.

sdrhodes1 commented 3 years ago

Been through and simplified the permissions we need :)

CanopusFalling commented 3 years ago

Looks done to me, how's the perms look to you @sdrhodes1 ?

sdrhodes1 commented 3 years ago

His Sam, yeah I sorted them few weeks back, think there was only 1 or 2 we could omit but did it and merger it in :)

On Tue, 6 Oct 2020, 10:41 Samuel Kent, notifications@github.com wrote:

Looks done to me, how's the perms look to you @sdrhodes1 https://github.com/sdrhodes1 ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SamTheDude/recycle-extension/issues/20#issuecomment-704154630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOI7GAN6YLOKOERB7EDC5FDSJLQ5TANCNFSM4RZJNH7Q .

CanopusFalling commented 3 years ago

Seems good to me, I made a few changes and omitted the perms that were not needed so we're all good on this front.