CanopusFalling / recycle-extension

Chrome extension to allow users to determine if a product is recyclable or not.
MIT License
2 stars 0 forks source link

Product engine fixes #21

Closed CanopusFalling closed 4 years ago

CanopusFalling commented 4 years ago

DO NOT MERGE UNTIL NO LONGER A WIP

Background detection engine and framework for the background page rework to make it easier to modify in future. Future changes may include: moving the recycle engine to the back end rather than using the front end to improve loading times, storing all previously looked up products for a period of time and adding feedback to our servers automatically (given the user opts in to this).

CanopusFalling commented 4 years ago

Ah, just realised I've added 2 reviewers to this while it's a WIP. I'll ping you both when this branch is finished, don't worry about this for the moment.

CanopusFalling commented 4 years ago

Product engine fixes completed as far as I can tell, @shamoilkhomosi and @sdrhodes1 if you could review this branch so that I know all the changes haven't introduced any bugs that would be great.

CanopusFalling commented 4 years ago

@sdrhodes1 and @shamoilkhomosi I'm going to test this again tomorrow morning then just merge it because it's needed for changes elsewhere and doesn't make too much sense to not make those while I have time. Raise any issues you have before then if you have the time.

CanopusFalling commented 4 years ago

Seems to work well enough, this is getting merged into the development branch so work can proceed.