search

CanopusFalling / recycle-extension

Chrome extension to allow users to determine if a product is recyclable or not.
MIT License
2 stars 0 forks source link

Fixed first time setup. #25

Closed CanopusFalling closed 4 years ago

CanopusFalling commented 4 years ago

Now will only run on the first time that the user adds an extension or if the user is updating past a version boundary where it needs to be set up again.

CanopusFalling commented 4 years ago

Seems ok to me, though am concerned about if the plugin updates, will the user then have to redo the setup page because it triggers the final if condition?

The final condition is there in case we ever update what information we need from the user at the setup stage or change the setup, currently it should never trigger for the user unless they reload the extension but I wouldn't say that is an average user that we need to worry about.

The point of the last bit is just that if a user goes between 2 versions when there has been an update to that section that is significant it will ask them to setup again. Though it is likely that we will never use it.

CanopusFalling commented 4 years ago

I'm going to test this on my laptop most of today day and see if I can cause the bug again, if not then it gets merged tomorrow morning.

CanopusFalling commented 4 years ago

Couldn't cause the bugs this branch fixed, merging branch now.