search

CanopusFalling / recycle-extension

Chrome extension to allow users to determine if a product is recyclable or not.
MIT License
2 stars 0 forks source link

Location selector clarity #32

Closed CanopusFalling closed 3 years ago

CanopusFalling commented 3 years ago

The popup currently shows the first location in the list while on it rather than the location that the user has selected. Everything works fine but this could be confusing to the end user so we should probably show their location to avoid that.

shamoilkhomosi commented 3 years ago

We can either pick their location as the default from the list so it shows instead of Adur,

Or once the location is updated we could just get rid of the list of locations drop-down for that session, and display that the location has been selected

CanopusFalling commented 3 years ago

So after the meeting we've come to the conclusion that we should move the location selector to outside the popup and only show it during the setup and on the settings page for the extension. We are also going to limit the number of choices available to the user to other, Birmingham, Sheffield, Manchester and Glasgow given those data sets will be the most refined.

We could also make it so that the popup still shows the current location to the user that if clicked on takes them to the settings page so they can still see where the extension thinks they are. Thoughts on this one @shamoilkhomosi ?

shamoilkhomosi commented 3 years ago

How about the plugin saying, "Your location: XXX", which is static text. Then below that, in smaller font size, we have "Not here?" which links them to the settings page, where they can change their location.

A couple of reasons why this might be good 1) The user might not know straight away where to change their location if we implement what you suggested. 2) It might be easier for us to split the functioning of the two lines: one which fetches the location from the backend and the other simply links them to settings.

But, all in all, I think we're thinking along the same lines, so should be fine whichever we opt for.

shamoilkhomosi commented 3 years ago

The first part of the issue has now been fixed. It's on the "errors" branch. User is displayed "You're at XXX" at all times to avoid any confusion. Close this issue if you think this fix suffices.