search

Cantera / cantera-website

Official Cantera Website
https://cantera.org
Other
14 stars 26 forks source link

Also build when PR targets testing branch #186

Closed ischoegl closed 2 years ago

ischoegl commented 2 years ago

See subject - this allows for checking of artifacts

speth commented 2 years ago

Doesn't this need to be on the testing branch? I had already included that change as part of #183.

bryanwweber commented 2 years ago

@speth I think so? I think it possibly matters more what's in the file when the PR is created? I dunno.

ischoegl commented 2 years ago

@speth … didn’t realize that you did the same on #183! From my perspective, I thought this needed to be on the main branch, unless CI is controlled by the targeted branch?

speth commented 2 years ago

The CI looks at the config in the PR -- otherwise, you wouldn't be able to test changes to the CI configuration without pushing directly to main (or a different target branch).

ischoegl commented 2 years ago

The CI looks at the config in the PR

... not sure. ~Otherwise this PR would have triggered a build?~ … Nevermind, of course it does. I was thinking about the wrong PR. Anyhow, having the same change here as in #183 ultimately won’t hurt.