Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
603 stars 346 forks source link

[SCons] Add deprecation warning for icc compiler #1542

Closed ischoegl closed 1 year ago

ischoegl commented 1 year ago

Changes proposed in this pull request

Log deprecation warning if icc is detected.

If applicable, fill in the issue number this pull request is fixing

Closes #1539

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1542 (9c959f3) into main (f89efe8) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1542   +/-   ##
=======================================
  Coverage   70.50%   70.50%           
=======================================
  Files         376      376           
  Lines       59075    59075           
  Branches    21219    21219           
=======================================
  Hits        41649    41649           
  Misses      14348    14348           
  Partials     3078     3078           
Impacted Files Coverage Δ
interfaces/cython/cantera/onedim.py 82.63% <100.00%> (ø)
src/oneD/Boundary1D.cpp 55.39% <100.00%> (ø)
src/oneD/StFlow.cpp 82.18% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more