Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
582 stars 342 forks source link

Fix serialization of phases with reactions from multiple YAML sections #1552

Closed ischoegl closed 11 months ago

ischoegl commented 11 months ago

Changes proposed in this pull request

Information on reactions in the phase input section is kept in user data, but cannot be used for the serialization, as there is no bookkeeping of where reactions originated. As it is not essential to retain this information, the user input is deleted.

If applicable, fill in the issue number this pull request is fixing

Closes #1522

If applicable, provide an example illustrating new features this pull request is introducing

See example provided in #1522.

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #1552 (c4e1fe3) into main (5f1014c) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1552   +/-   ##
=======================================
  Coverage   70.46%   70.47%           
=======================================
  Files         379      379           
  Lines       59091    59093    +2     
  Branches    21228    21230    +2     
=======================================
+ Hits        41641    41643    +2     
  Misses      14369    14369           
  Partials     3081     3081           
Impacted Files Coverage Δ
src/base/Solution.cpp 79.56% <100.00%> (+0.22%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more