Closed ischoegl closed 11 months ago
Merging #1553 (3258c2e) into main (5f1014c) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #1553 +/- ##
=======================================
Coverage 70.46% 70.46%
=======================================
Files 379 379
Lines 59091 59091
Branches 21228 21228
=======================================
Hits 41641 41641
Misses 14369 14369
Partials 3081 3081
Impacted Files | Coverage Δ | |
---|---|---|
src/kinetics/PlogRate.cpp | 89.52% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Changes proposed in this pull request
Per discussion in #1405, the previous set of temperatures used for validation of P-log rates is a somewhat arbitrary set. Some mechanisms fail for 200 K but work fine for 300 K and up. This work-around was discussed as a band-aid to make some relevant mechanisms work (AramcoMech 3.0 / NUIGMech 1.1), although a more long-term solution should be found.
If applicable, fill in the issue number this pull request is fixing
Partially addresses #1405
Checklist
scons build
&scons test
) and unit tests address code coverage