Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
582 stars 342 forks source link

Standardize code #1565

Closed ischoegl closed 11 months ago

ischoegl commented 11 months ago

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

Partially addresses Cantera/enhancements#181

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #1565 (2f8ed63) into main (4dd28c4) will increase coverage by 0.01%. The diff coverage is 85.71%.

:exclamation: Current head 2f8ed63 differs from pull request most recent head a7e0e46. Consider uploading reports for the commit a7e0e46 to get more accurate results

@@            Coverage Diff             @@
##             main    #1565      +/-   ##
==========================================
+ Coverage   70.47%   70.48%   +0.01%     
==========================================
  Files         379      379              
  Lines       59093    59093              
  Branches    21230    21230              
==========================================
+ Hits        41643    41653      +10     
+ Misses      14369    14360       -9     
+ Partials     3081     3080       -1     
Files Changed Coverage Δ
include/cantera/base/AnyMap.h 80.00% <ø> (ø)
include/cantera/base/Array.h 82.75% <ø> (ø)
include/cantera/base/global.h 81.81% <ø> (ø)
include/cantera/base/utilities.h 96.66% <ø> (ø)
include/cantera/equil/MultiPhase.h 100.00% <ø> (ø)
include/cantera/equil/MultiPhaseEquil.h 90.47% <ø> (ø)
include/cantera/kinetics/BlowersMaselRate.h 97.50% <ø> (ø)
include/cantera/kinetics/Kinetics.h 32.66% <ø> (ø)
include/cantera/kinetics/ReactionPath.h 67.44% <ø> (ø)
include/cantera/kinetics/StoichManager.h 95.46% <ø> (ø)
... and 32 more

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ischoegl commented 11 months ago

Applied the items from Cantera/enhancements#181 that are easiest (mostly removing the redundant compositionMap typedef). I can add more, but won't unless prompted.

ischoegl commented 11 months ago

Rebased and ready for review. Doxygen bits moved to #1567.