Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
582 stars 342 forks source link

Standardize code cont'd #1568

Closed ischoegl closed 11 months ago

ischoegl commented 11 months ago

Changes proposed in this pull request

Implement remaining items from Cantera/enhancements#181

If applicable, fill in the issue number this pull request is fixing

Closes Cantera/enhancements#181

Checklist

codecov[bot] commented 11 months ago

Codecov Report

Merging #1568 (0622402) into main (e0a2f11) will increase coverage by 0.03%. The diff coverage is 82.70%.

@@            Coverage Diff             @@
##             main    #1568      +/-   ##
==========================================
+ Coverage   70.50%   70.53%   +0.03%     
==========================================
  Files         379      379              
  Lines       59112    59110       -2     
  Branches    21232    21232              
==========================================
+ Hits        41675    41695      +20     
+ Misses      14361    14340      -21     
+ Partials     3076     3075       -1     
Files Changed Coverage Δ
include/cantera/base/ExtensionManager.h 27.27% <0.00%> (ø)
include/cantera/base/Interface.h 100.00% <ø> (ø)
include/cantera/base/NoExitLogger.h 0.00% <0.00%> (ø)
include/cantera/base/ValueCache.h 100.00% <ø> (ø)
include/cantera/base/YamlWriter.h 100.00% <ø> (ø)
include/cantera/equil/vcs_MultiPhaseEquil.h 100.00% <ø> (ø)
include/cantera/equil/vcs_SpeciesProperties.h 100.00% <ø> (ø)
include/cantera/kinetics/MultiRateBase.h 100.00% <ø> (ø)
include/cantera/kinetics/ReactionData.h 67.85% <0.00%> (ø)
include/cantera/kinetics/solveSP.h 100.00% <ø> (ø)
... and 258 more

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ischoegl commented 11 months ago

@speth ... per request, I added all remaining 'standardizations' in a single PR. I did not touch include/cantera/numerics/ctlapack.h, which continues to use doublereal.

ischoegl commented 11 months ago

Rebased to resolve merge conflict after #1570

ischoegl commented 11 months ago

Thanks for pushing corrections/updates directly, @speth ... didn't think about Matlab not using the namespace / ct_defs.h. Regarding reformatting, I did a regex search for the most obvious changes, but apparently missed numerous spots. Probably I was too opportunistic ... .

Regarding leaving doublereal in ctlapack.h, I wasn't sure about the history, and decided to leave it (in part also because of the comment in config.h.in you mentioned). I'm not too concerned about doublereal surviving a little longer, as I'm sure it makes no difference to the compiler.

Unless you have other suggestions, this is good to go from my side. Let's see what merge conflicts will arise in #1567 (should be easy to clean up though).