Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
603 stars 346 forks source link

Fix for Sundials 6.6 behavior changes #1570

Closed speth closed 1 year ago

speth commented 1 year ago

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

Resolves #1554 Resolves #1195

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1570 (652ed24) into main (6ba497c) will increase coverage by 0.05%. Report is 3 commits behind head on main. The diff coverage is 84.14%.

@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
+ Coverage   70.45%   70.51%   +0.05%     
==========================================
  Files         379      379              
  Lines       59093    59112      +19     
  Branches    21230    21232       +2     
==========================================
+ Hits        41636    41682      +46     
+ Misses      14376    14354      -22     
+ Partials     3081     3076       -5     
Files Changed Coverage Δ
include/cantera/numerics/CVodesIntegrator.h 31.25% <ø> (ø)
include/cantera/numerics/IdasIntegrator.h 0.00% <ø> (ø)
src/zeroD/Reactor.cpp 85.47% <50.00%> (ø)
src/numerics/CVodesIntegrator.cpp 71.65% <75.55%> (+5.71%) :arrow_up:
src/numerics/IdasIntegrator.cpp 72.16% <95.83%> (+1.41%) :arrow_up:
include/cantera/kinetics/ImplicitSurfChem.h 100.00% <100.00%> (ø)
include/cantera/numerics/FuncEval.h 42.85% <100.00%> (ø)
include/cantera/zeroD/Reactor.h 61.76% <100.00%> (ø)
include/cantera/zeroD/ReactorNet.h 76.66% <100.00%> (ø)
src/zeroD/ReactorNet.cpp 81.21% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more