Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
582 stars 342 forks source link

Sphinx argparse #1581

Closed ischoegl closed 10 months ago

ischoegl commented 10 months ago

Changes proposed in this pull request

Improve documentation of converter scripts.

If applicable, fill in the issue number this pull request is fixing

Closes #1577

May create pages that could receive website content (see Cantera/enhancements#178)

Checklist

codecov[bot] commented 10 months ago

Codecov Report

Merging #1581 (0539ff5) into main (4b30fa7) will increase coverage by 0.08%. Report is 4 commits behind head on main. The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
+ Coverage   70.51%   70.59%   +0.08%     
==========================================
  Files         379      379              
  Lines       59118    59143      +25     
  Branches    21237    21253      +16     
==========================================
+ Hits        41686    41752      +66     
+ Misses      14359    14319      -40     
+ Partials     3073     3072       -1     
Files Changed Coverage Δ
interfaces/cython/cantera/ck2yaml.py 84.16% <0.00%> (ø)
interfaces/cython/cantera/cti2yaml.py 70.87% <50.00%> (-0.13%) :arrow_down:
interfaces/cython/cantera/ctml2yaml.py 71.81% <50.00%> (-0.10%) :arrow_down:
interfaces/cython/cantera/yaml2ck.py 62.67% <50.00%> (-0.32%) :arrow_down:

... and 10 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ischoegl commented 10 months ago

@speth ... this should likewise be ready. I added module-level ck2yaml autodoc documentation, and also deprecated the --id argument (which had already triggered warnings).

PS: Once we get to 3.0, it may make sense to use argparse for ck2yaml as well, so we get consistent documentation. I also believe that tutorials can be merged into this documentation directly.

speth commented 10 months ago

Yes, I agree that modifying ck2yaml to also use argparse would make sense after the 3.0 release.