Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
582 stars 342 forks source link

Fix restoring ImpingingJet from HDF5 #1585

Closed ischoegl closed 10 months ago

ischoegl commented 10 months ago

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

Closes #1580

If applicable, provide an example illustrating new features this pull request is introducing

Run samples/python/onedim/stagnation_flame.py example, then

In [1]: import cantera as ct
   ...: gas = ct.Solution('h2o2.yaml')
   ...: flame = ct.ImpingingJet(gas)
   ...: flame.restore('stagnation_flame_data/stagnation_flame.h5', 'mdot-0')
Out[1]:
{'cantera-version': '3.0.0b1',
 'date': 'Fri Aug 11 10:54:37 2023',
 'description': 'mdot = 0.06 kg/m2/s',
 'generator': 'Cantera SolutionArray',
 'git-commit': "'c92138c12'"}

Checklist

codecov[bot] commented 10 months ago

Codecov Report

Merging #1585 (0d854fb) into main (4b30fa7) will increase coverage by 0.07%. Report is 1 commits behind head on main. The diff coverage is 40.74%.

@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
+ Coverage   70.51%   70.58%   +0.07%     
==========================================
  Files         379      379              
  Lines       59118    59134      +16     
  Branches    21237    21253      +16     
==========================================
+ Hits        41686    41739      +53     
+ Misses      14359    14322      -37     
  Partials     3073     3073              
Files Changed Coverage Δ
include/cantera/oneD/Boundary1D.h 57.89% <ø> (+8.91%) :arrow_up:
src/oneD/Sim1D.cpp 69.20% <20.00%> (-1.23%) :arrow_down:
src/oneD/Boundary1D.cpp 60.08% <100.00%> (+4.68%) :arrow_up:

... and 5 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ischoegl commented 10 months ago

Thanks, @speth ... I believe this is ready to merge.