Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
602 stars 346 forks source link

Implement removals indicated by deprecations in Cantera 3.0 #1605

Closed speth closed 1 year ago

speth commented 1 year ago

Changes proposed in this pull request

I tried to break up the "interesting" changes into separate commits. This might be easiest to review on a commit-by-commit basis, where the commits "Remove code deprecated in Cantera 3.0" and "Remove deprecated Python code" consist almost entirely of straight removals of deprecated code.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #1605 (fcab50a) into main (806842d) will increase coverage by 2.07%. The diff coverage is 71.07%.

@@            Coverage Diff             @@
##             main    #1605      +/-   ##
==========================================
+ Coverage   70.59%   72.66%   +2.07%     
==========================================
  Files         379      370       -9     
  Lines       59185    56259    -2926     
  Branches    21270    20353     -917     
==========================================
- Hits        41781    40882     -899     
+ Misses      14325    12374    -1951     
+ Partials     3079     3003      -76     
Files Changed Coverage Δ
include/cantera/base/Array.h 96.00% <ø> (ø)
include/cantera/kinetics/BulkKinetics.h 100.00% <ø> (+50.00%) :arrow_up:
include/cantera/kinetics/ChebyshevRate.h 100.00% <ø> (ø)
include/cantera/kinetics/Falloff.h 93.02% <ø> (+11.39%) :arrow_up:
include/cantera/kinetics/ImplicitSurfChem.h 100.00% <ø> (ø)
include/cantera/kinetics/InterfaceKinetics.h 87.50% <ø> (ø)
include/cantera/kinetics/InterfaceRate.h 87.87% <ø> (ø)
include/cantera/kinetics/Kinetics.h 32.43% <ø> (-0.24%) :arrow_down:
include/cantera/kinetics/PlogRate.h 100.00% <ø> (ø)
include/cantera/kinetics/Reaction.h 90.00% <ø> (+5.00%) :arrow_up:
... and 115 more

... and 7 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more