Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
582 stars 342 forks source link

Container-based GH actions #1608

Closed ischoegl closed 10 months ago

ischoegl commented 10 months ago

Changes proposed in this pull request

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

codecov[bot] commented 10 months ago

Codecov Report

Merging #1608 (675e90e) into main (e2c446c) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
- Coverage   72.66%   72.65%   -0.02%     
==========================================
  Files         370      370              
  Lines       56259    56255       -4     
  Branches    20353    20353              
==========================================
- Hits        40882    40873       -9     
- Misses      12374    12379       +5     
  Partials     3003     3003              
Files Changed Coverage Δ
interfaces/cython/cantera/_utils.pyx 91.92% <ø> (+0.51%) :arrow_up:
interfaces/cython/cantera/onedim.py 84.97% <ø> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ischoegl commented 10 months ago

~As mentioned on top, the new runner should be moved before merging. It is currently in main.yaml so the CI is actually triggered and output can be reviewed.~ Edit: now moved to final location.

ischoegl commented 10 months ago

I moved the docker tests to post-merge-tests to expedite things. Fwiw, the output of the CI run can be reviewed in previously successful GH Action runs, i.e.:

ischoegl commented 10 months ago

@speth ... thanks for the feedback! No problem with leaving mingw where it was. Other than that, I believe we have a decent template to be used for regression tests with other Linux flavors in the future.