Closed ischoegl closed 9 months ago
Merging #1616 (78b187e) into main (b2f383a) will increase coverage by
0.03%
. Report is 5 commits behind head on main. The diff coverage is71.42%
.
@@ Coverage Diff @@
## main #1616 +/- ##
==========================================
+ Coverage 72.66% 72.70% +0.03%
==========================================
Files 370 370
Lines 56255 56257 +2
Branches 20353 20351 -2
==========================================
+ Hits 40880 40903 +23
+ Misses 12372 12357 -15
+ Partials 3003 2997 -6
Files Changed | Coverage Δ | |
---|---|---|
interfaces/cython/cantera/cti2yaml.py | 70.87% <ø> (ø) |
|
interfaces/cython/cantera/ctml2yaml.py | 68.61% <ø> (ø) |
|
interfaces/cython/cantera/solutionbase.pyx | 94.55% <50.00%> (+2.91%) |
:arrow_up: |
interfaces/cython/cantera/yaml2ck.py | 65.49% <66.66%> (+2.81%) |
:arrow_up: |
interfaces/cython/cantera/ck2yaml.py | 84.65% <72.97%> (+0.30%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Ended up adding fixes / bandaids for #1610 / #1611. This is ready for a review.
@bryanwweber ... thank you for the suggestions!
Changes proposed in this pull request
ck2yaml
toargparse
in order to be consistent with other converter scriptssphinx-argparse
Solution.write_chemkin
bugsIf applicable, fill in the issue number this pull request is fixing
Closes #1611, partially addresses #1610
If applicable, provide an example illustrating new features this pull request is introducing
ck2yaml
now has the following help text (generated byargparse
)While not the main issue, this now works:
Checklist
scons build
&scons test
) and unit tests address code coverage