Closed speth closed 9 months ago
Merging #1621 (56487cd) into main (329952d) will decrease coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1621 +/- ##
==========================================
- Coverage 72.72% 72.71% -0.01%
==========================================
Files 370 370
Lines 56287 56286 -1
Branches 20369 20369
==========================================
- Hits 40932 40931 -1
Misses 12358 12358
Partials 2997 2997
Files | Coverage Δ | |
---|---|---|
interfaces/cython/cantera/_cantera.pyx | 100.00% <100.00%> (ø) |
|
samples/clib/demo.c | 77.77% <ø> (ø) |
|
samples/cxx/bvp/BoundaryValueProblem.h | 86.56% <ø> (ø) |
|
samples/cxx/bvp/blasius.cpp | 87.50% <ø> (ø) |
|
samples/cxx/flamespeed/flamespeed.cpp | 83.89% <ø> (ø) |
|
samples/cxx/openmp_ignition/openmp_ignition.cpp | 82.85% <ø> (ø) |
|
samples/cxx/rankine/rankine.cpp | 91.83% <ø> (ø) |
|
samples/f77/demo_ftnlib.cpp | 53.84% <ø> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
It may make sense to wait what happens with the contribution to the upstream library?
Yes, we can wait to merge this in case there are any API changes requested upstream. I don't think I want to wait for the next release of sphinx-gallery
, though. I may start building another PR on top of this one with more documentation updates.
The "download all" buttons and corresponding zip files are something I still need to fix upstream.
For the individual examples, the name is the one used by Pygments (first column here), which uses "Fortran" for F90-style "free format" and "FortranFixed" for the older fixed-width format. I think it's a pretty minor wart.
Thanks for doing this Ray! I'm happy we'll be able to link to API docs from the examples, and that you've got all the examples building. Once this goes in, I'll rework the ongoing sphinx migration to use this instead of my bespoke solution.
The "download all" buttons and corresponding zip files are something I still need to fix upstream.
Thanks for the upstream fix - I retriggered GH actions, and things are taken care of :tada:
For the individual examples, the name is the one used by Pygments (first column here), which uses "Fortran" for F90-style "free format" and "FortranFixed" for the older fixed-width format. I think it's a pretty minor wart.
Thanks for the explanation. It indeed is a minor wart.
🥳 ... sphinx-gallery
PR is merged.
Changes proposed in this pull request
sphinx-gallery
to render the examples.sphinx-tags
to parse the example keywords and create index pages for each tagsphinx-gallery
andsphinx-tags
Notes:
sphinx-gallery
can't run the other language examples (at least for the time being), those galleries are full of the default image.sphinx-gallery
is pretty awesome.sphinx-gallery
that includes a pending PR to introduce the ability to parse examples in languages other than Python.sphinx-tags
that includes a few fixes I introduced. This extension is very small (a single file) so we could just vendor it if we're going to introduce significant customizations.If applicable, fill in the issue number this pull request is fixing
If applicable, provide an example illustrating new features this pull request is introducing
The page for a Python example:
Part of an index page:
Checklist
scons build
&scons test
) and unit tests address code coverage