Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
581 stars 342 forks source link

Fix converting surface mechanisms that use a separate thermo data file #1637

Closed speth closed 6 months ago

speth commented 8 months ago

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

This fixes an issue that was originally reported in this Users' Group post

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

codecov[bot] commented 8 months ago

Codecov Report

Merging #1637 (0fc24ea) into main (3a9bc6a) will decrease coverage by 0.01%. The diff coverage is 57.89%.

@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
- Coverage   72.69%   72.68%   -0.01%     
==========================================
  Files         370      370              
  Lines       56298    56302       +4     
  Branches    20375    20403      +28     
==========================================
- Hits        40925    40923       -2     
+ Misses      12376    12371       -5     
- Partials     2997     3008      +11     
Files Coverage Δ
interfaces/cython/cantera/ck2yaml.py 84.48% <57.89%> (-0.18%) :arrow_down:

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

speth commented 6 months ago

The failing linter test is expected -- the point was to test messy input with tabs and trailing spaces. I didn't think it was worth trying to add exclude rules, given this won't show up again unless there are modifications to this or other similar input files.