3.0 liquid pool - Githubissues

Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite

https://cantera.org

Other

581 stars 342 forks source link

3.0 liquid pool #1639

Open LJ1356 opened 8 months ago

LJ1356 commented 8 months ago

Changes proposed in this pull request

-

If applicable, fill in the issue number this pull request is fixing

Closes #

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

[ ] The pull request includes a clear description of this code change
[ ] Commit messages have short titles and reference relevant issues
[ ] Build passes (scons build & scons test) and unit tests address code coverage
[ ] Style & formatting of contributed code follows contributing guidelines
[ ] The pull request is ready for review

ischoegl commented 8 months ago

Thanks for the pull request! Could you please modify this PR so it targets the main branch of the repository? Thank you!

speth commented 8 months ago

Thanks for starting this pull request, @LJ1356. In addition to @ischoegl's suggestion, can you please describe the feature this PR is implementing in the summary? Do you have a document or any references you can share that describe the model that is implemented here?

LJ1356 commented 8 months ago

I apologized for the pull request. It is my first time to code with git and github. I did not realized when I made this PR.

I folked Cantera to my own repo and I just planed to test on my own repo because these codes is still in development.

I developed it for counterflow flame with liquid pool boundary condition at beginning of this year based on Cantera 3.0.0. I am not pretty sure if it still work when I change PR to main branch. I may need some time to make it compatible with main branch.

speth commented 8 months ago

No need to apologize! I think this is a feature that would be worth integrating into Cantera, once you're further along in the development. Please feel free to leave this PR open, but convert it to a "draft" PR -- there should be a link on the right side of the page that does this. That way, people will be aware that you're working on this, but will know that it isn't ready for an in-depth review yet.

LJ1356 commented 8 months ago

Hi speth, I appreciate for your suggestions. I have converted it to draft. After I finished development, I will request pull to main branch.