[scons] Bump python_max_p1_version to 3.13

Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite

https://cantera.org

Other

581 stars 342 forks source link

[scons] Bump python_max_p1_version to 3.13 #1648

Closed matthiasdiener closed 6 months ago

matthiasdiener commented 6 months ago

Followup of #1604, #1612. See also https://github.com/conda-forge/cantera-feedstock/pull/35 for context.

Changes proposed in this pull request

Allows building the package with Python 3.12

If applicable, fill in the issue number this pull request is fixing

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

[x] The pull request includes a clear description of this code change
[x] Commit messages have short titles and reference relevant issues
[ ] Build passes (scons build & scons test) and unit tests address code coverage
[x] Style & formatting of contributed code follows contributing guidelines
[x] The pull request is ready for review

bryanwweber commented 6 months ago

I think we also need to bump the CI runner configuration to make sure we test on 3.12.

matthiasdiener commented 6 months ago

I think we also need to bump the CI runner configuration to make sure we test on 3.12.

Thanks, I added 3.12 to the CI configs.

bryanwweber commented 6 months ago

It looks like we might need to bump Cython to fix that build, but I'm not sure why it's only failing on macOS. Very strange.

matthiasdiener commented 6 months ago

It looks like we might need to bump Cython to fix that build, but I'm not sure why it's only failing on macOS. Very strange.

As far as I can see, the cython version is the same across all builds (3.0.6). I believe it is just using an old setuptools version for the macos build, which I hopefully resolved in f0f7d28.

matthiasdiener commented 6 months ago

That seems to have fixed it. The remaining CI errors look the same as in main, so I think this is ready to go.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (60ea75a) 72.68% compared to head (880de60) 72.68%. Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1648 +/- ## ========================================== - Coverage 72.68% 72.68% -0.01% ========================================== Files 370 370 Lines 56298 56302 +4 Branches 20403 20403 ========================================== + Hits 40922 40923 +1 - Misses 12369 12371 +2 - Partials 3007 3008 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.