Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
581 stars 342 forks source link

Minor adjustment to debugging output in Sim1d.cpp for log levels >7 #1660

Closed wandadars closed 5 months ago

wandadars commented 5 months ago

Changes proposed in this pull request

I added the "true" overwrite flag to the debugging save() and saveResidual() calls in the Sim1d.cpp file to prevent code-stopping errors. I cam across this when trying to debug my work in #1622 . @ischoegl suggested putting the changes in a separate pull request.

To reproduce the error, run a 1D flow case that experiences failures in the steady newton solve, after taking a few successful newton solves. The error consists of the data group at the highest level already existing in the debug file, causing the code to error out.

Checklist

codecov[bot] commented 5 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7efb996) 72.75% compared to head (6604a7e) 72.76%.

Files Patch % Lines
src/oneD/Sim1D.cpp 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1660 +/- ## ======================================= Coverage 72.75% 72.76% ======================================= Files 375 375 Lines 56584 56584 Branches 20494 20494 ======================================= + Hits 41168 41171 +3 + Misses 12401 12399 -2 + Partials 3015 3014 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.