Closed ischoegl closed 5 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
01a0284
) 72.75% compared to head (faddc8f
) 72.78%.
Files | Patch % | Lines |
---|---|---|
include/cantera/zeroD/ReactorBase.h | 58.33% | 0 Missing and 5 partials :warning: |
src/zeroD/Wall.cpp | 83.33% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
My only request here is to document what upstream deprecation warning is resolved by installing
pyarrow
as part of the commit message.
:+1: done
Do we need to update the dependencies of some of the examples?
I don't think so - it's just pandas complaining that it will require pyarrow down the line.
Changes proposed in this pull request
Currently existing guards are largely specific to the implementation of the Python API (example: retrieving temperature for an empty reactor fails when attempting to load the current reactor state into a thermo object). As underlying C++ code is difficult to reach from Python (but may be exposed elsewhere), unit tests are added for C++ directly.
If applicable, fill in the issue number this pull request is fixing
Fixes #1623
If applicable, provide an example illustrating new features this pull request is introducing
Example taken from #1623:
Other thoughts
An alternative to the added guards is to prevent the creation of empty (or unconnected) 0-D objects altogether (which should likely be done when moving from raw pointers to shared pointers for various held objects -
m_thermo
, etc.). As this is more involved and will require a deprecation cycle, the guards proposed in this PR are still appropriate.Checklist
scons build
&scons test
) and unit tests address code coverage